feat: link scheduling #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
AfonsoMartins26
changed the title
joaodiaslobo
requested changes
Sep 20, 2024
MarioRodrigues10
requested changes
Sep 20, 2024
AfonsoMartins26
requested review from
MarioRodrigues10,
joaodiaslobo,
nunom27 and
FilipeR13
joaodiaslobo
requested changes
Sep 23, 2024
AfonsoMartins26
requested review from
joaodiaslobo
and removed request for
JulioJPinto
The opacity is working but it doesn't go away when the link gets to the home page.... 😿 |
MarioRodrigues10
requested changes
Oct 7, 2024
Comment on lines
+18
to
+19
| <:col :let={{_id, _link}}> | ||
| <% publish_future = _link.publish_at && DateTime.compare(_link.publish_at, DateTime.utc_now()) == :gt %> |
There was a problem hiding this comment.
Suggested change
| <:col :let={{_id, _link}}> | |
| <% publish_future = _link.publish_at && DateTime.compare(_link.publish_at, DateTime.utc_now()) == :gt %> | |
| <:col :let={{_id, link}}> | |
| <% publish_future = link.publish_at && DateTime.compare(link.publish_at, DateTime.utc_now()) == :gt %> |
joaodiaslobo
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Everything backend-wise is great! Good job!
Now, to represent a scheduled link on the backoffice table, we should probably use JavaScript to make it more interactive and up to date. Learn more about Phoenix hooks here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.